ref -> rev; fix some warns; cov 33.46%

This commit is contained in:
🪞👃🪞 2025-03-04 01:12:37 +02:00
parent bcc3f5809e
commit 60e4bb49b2
14 changed files with 43 additions and 43 deletions

View file

@ -47,27 +47,27 @@ pub trait MidiRecordApi: HasClock + HasPlayClip + HasMidiIns {
if let Some((started, ref clip)) = self.play_clip().clone() {
self.record_clip(scope, started, clip, midi_buf);
}
if let Some((start_at, clip)) = &self.next_clip() {
if let Some((_start_at, _clip)) = &self.next_clip() {
self.record_next();
}
}
fn record_clip (
&mut self,
scope: &ProcessScope,
started: Moment,
clip: &Option<Arc<RwLock<MidiClip>>>,
midi_buf: &mut Vec<Vec<Vec<u8>>>
scope: &ProcessScope,
started: Moment,
clip: &Option<Arc<RwLock<MidiClip>>>,
_midi_buf: &mut Vec<Vec<Vec<u8>>>
) {
if let Some(clip) = clip {
let sample0 = scope.last_frame_time() as usize;
let start = started.sample.get() as usize;
let recording = self.recording();
let _recording = self.recording();
let timebase = self.clock().timebase().clone();
let quant = self.clock().quant.get();
let mut clip = clip.write().unwrap();
let length = clip.length;
for input in self.midi_ins_mut().iter() {
for (sample, event, bytes) in parse_midi_input(input.port().iter(scope)) {
for (sample, event, _bytes) in parse_midi_input(input.port().iter(scope)) {
if let LiveEvent::Midi { message, .. } = event {
clip.record_event({
let sample = (sample0 + sample - start) as f64;

View file

@ -64,13 +64,13 @@ impl Default for MidiPlayer {
impl MidiPlayer {
pub fn new (
name: impl AsRef<str>,
jack: &Jack,
_jack: &Jack,
clock: Option<&Clock>,
clip: Option<&Arc<RwLock<MidiClip>>>,
_midi_from: &[PortConnect],
_midi_to: &[PortConnect],
) -> Usually<Self> {
let name = name.as_ref();
let _name = name.as_ref();
let clock = clock.cloned().unwrap_or_default();
Ok(Self {
midi_ins: vec![],//JackMidiIn::new(jack, format!("M/{name}"), midi_from)?,],

View file

@ -118,7 +118,7 @@ pub struct ClipLength {
focus: Option<ClipLengthFocus>,
}
impl ClipLength {
fn new (pulses: usize, focus: Option<ClipLengthFocus>) -> Self {
fn _new (pulses: usize, focus: Option<ClipLengthFocus>) -> Self {
Self { ppq: PPQ, bpb: 4, pulses, focus }
}
fn bars (&self) -> usize {
@ -458,7 +458,7 @@ command!(|self: ClipLengthCommand, state: MidiPool|{
Tick => { *length = length.saturating_sub(1) },
},
Set(length) => {
let mut old_length = None;
let old_length;
{
let clip = state.clips()[clip].clone();//.write().unwrap();
old_length = Some(clip.read().unwrap().length);